Add GCP Objectstore SDK instead of JClouds #1723
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMCROSSITXSADEPLOY-3313
Yavor16
force-pushed
the
adopt-gcp-os-sdk
branch
from
7b20da8 to
ac576b8
Compare
multiapps-controller-persistence/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...rg/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorageTest.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
|
|
||
| public class ObjectStoreUtil { | ||
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(ObjectStoreUtil.class); |
There was a problem hiding this comment.
the log value of these classes was DEBUG:
org.cloudfoundry.multiapps.controller.persistence.services.ObjectStoreFileStorage: DEBUG
consider adding it in manifest + product cf hcp
...rg/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorageTest.java
Outdated
Show resolved
Hide resolved
...y/multiapps/controller/web/configuration/bean/factory/ObjectStoreFileStorageFactoryBean.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
Comment on lines
111
to
116
| public Storage createObjectStoreStorage(Map<String, Object> credentials) { | ||
| return StorageOptions.newBuilder() | ||
| .setCredentials(getGcpCredentialsSupplier(credentials)) | ||
| .build() | ||
| .getService(); | ||
| } |
There was a problem hiding this comment.
StorageOptions and GCP provider has a built in retry strategy.
We can utilize it and remove the custom retry strategies? I mean we can move Storage creation in the GCP client and in the info creator only to provide the necessary credentials. We're binding this class with gcp classes now.
What do you think?
There was a problem hiding this comment.
StorageOptions.newBuilder()
.setCredentials(getGcpCredentialsSupplier(credentials))
.setRetrySettings()
.build()
.getService();
Yavor16
force-pushed
the
adopt-gcp-os-sdk
branch
from
097220f to
704d12b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.